ci(governance): re-pin to post-#464 standards (baseline filter now actually runs)#172
Merged
Merged
Conversation
…actually runs Follow-up to #171. That PR bumped the governance-reusable pin to standards 832b157 (which had #455's baseline-filter wire-in), but #455 had a bug: the scan's by-design exit-on-findings aborted the step under `bash -e` before the filter ran, so the gate stayed mechanically broken (verified on #171's own CI: "scan complete: 18 findings; exit 1" with zero apply-baseline.sh output). standards#464 fixed that (`|| true` + a JSON-array crash guard). This re-pins governance-reusable 832b157 -> f81bb04 (current standards main, both #455 and #464 present) so neurophone's validate-hypatia-baseline actually reaches the filter. Still surgical: the other five standards reusables stay at 7c9db0e. Note: a newer hypatia HEAD now reports 18 findings vs the 14 neurophone's .hypatia-baseline.json was written against (#168), so this may still surface un-baselined findings (incl. a new critical) that need honest per-repo handling — not blind baselining. This PR's CI is the diagnostic that surfaces exactly which. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0172RBMz3qYjb1ttzD2i7RNh
|
hyperpolymath
marked this pull request as ready for review
July 3, 2026 03:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #171. That PR pinned standards
832b157(which had #455's baseline-filter wire-in), but #455 had a bug — the scan's by-design exit-on-findings aborted the step underbash -ebefore the filter ran, so the gate was still mechanically broken. standards#464 fixed that (|| true+ a JSON-array crash guard). This re-pinsgovernance-reusable832b157→f81bb04(current standardsmain, both #455 and #464 present).Still surgical: the other five standards reusables stay at
7c9db0e.What this PR is for (diagnostic)
This is the run where
validate-hypatia-baselinefinally reachesapply-baseline.sh. The newer hypatia HEAD now reports 18 findings vs the 14 neurophone's.hypatia-baseline.jsonwas written against (#168), so the outcome will be one of:I'll read this PR's filter output and report exactly which findings are kept.
Draft pending that diagnosis.
🤖 Generated with Claude Code
https://claude.ai/code/session_0172RBMz3qYjb1ttzD2i7RNh
Generated by Claude Code